Re: menubar segfault

[Jason Rumney]

Scott Lanning <address@hidden> writes:

> I followed your advice and moved Fx_hide_tip from function
> `menu_highlight_callback' in src/xmenu.c to where I think the help
> event is handled, `kbd_buffer_get_event' in src/keyboard.c.  If I
> understand correctly, then here is a patch to version 21.1.50.17 that
> doesn't seem to segfault (also w32 version for you :)

Unfortunately the patch to kbd_buffer_get_event causes other tooltips
(over tool-bar items, modeline etc) to hide when the mouse moves even
one pixel. Previously, the tip only hid when the mouse moved off the
item completely. If this can't be solved some other way, we need to
decide whether the fix is worth this side effect before installing it.

> Sat Jan 5 23:49:22 2002
> +++ src/keyboard.c Sat Jan 5 23:49:20 2002
> @@ -3747,6 +3747,8 @@ list5 (frame, help, window, object, position));
> clear_event (event); kbd_fetch_ptr = event + 1;
> + Fx_hide_tip ();
>         }
>        else if (event->kind == FOCUS_IN_EVENT) { diff -urN


I have reverted the previous changes to xterm.c and w32term.c in the
meantime, as they are clearly not right.

-- 
Jason Rumney