[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug in Ange-FTP with renaming files
From: |
Kai Großjohann |
Subject: |
Re: Bug in Ange-FTP with renaming files |
Date: |
Sun, 06 Jul 2003 16:56:34 +0200 |
User-agent: |
Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux) |
address@hidden (Kai Großjohann) writes:
> address@hidden (Kai Großjohann) writes:
>
>> I shall try to investigate further, but I thought it would be good to
>> let you know -- more eyes find more bugs...
>
> Here is something fishy I found: after the last `R' command in dired,
> dired-rename-file calls dired-rename-subdir, but the args specified
> are not directories
Right. This always happens:
(defun dired-rename-file (file newname ok-if-already-exists)
(dired-handle-overwrite newname)
(rename-file file newname ok-if-already-exists) ; error is caught in
-create-files
;; Silently rename the visited file of any buffer visiting this file.
(and (get-file-buffer file)
(with-current-buffer (get-file-buffer file)
(set-visited-file-name newname nil t)))
(dired-remove-file file)
;; See if it's an inserted subdir, and rename that, too.
(dired-rename-subdir file newname))
Shouldn't dired-rename-subdir be conditioned on either file or newname
being a directory? Or perhaps both? Or shouldn't dired-rename-subdir
take care to do the right thing with non-directories?
I'm getting confused now.
--
~/.signature