[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: prompt of cvs-do-removal
From: |
Masatake YAMATO |
Subject: |
Re: prompt of cvs-do-removal |
Date: |
Sun, 31 Aug 2003 11:14:21 +0900 (JST) |
> Masatake YAMATO wrote:
>
> > P.S. Thank you for reviewing my patch every time.
> ...
> > - (yes-or-no-p (format "Delete %d files? " (length files)))
> > + (if (eq 1 (length files))
> > + (yes-or-no-p (format "Delete file: \"%s\" ? "
> > (cvs-fileinfo->file (car files))))
> > + (yes-or-no-p (format "Delete %d files? " (length
> > files))))
>
> Wouldn't = be more appropriate than eq there? And you may want to bind
> (length files) to a local
>
> variable, so you don't have to re-evaluate it.
>
> --
> Kevin Rodgers
Thank you for suggestions. I've applied your suggestions and installed.
Masatake YAMATO