Re: Several suggestions for image support

[Kenichi Handa]

In article <address@hidden>, address@hidden (Kim F. Storm) writes:
> With my change, if you have just ONE character in the frame default
> font in the line, it will be shown exactly as before.  Also, if the
> line is empty, ie. only contains the newline, it is also shown as
> before.

> The only time you will see my change in effect is if you have a line
> where ALL glyphs are lower than the default frame line height; in that
> case, the line is only as high as the tallest character on that line.

With the latest code, when I do this:

(make-face 'small)
(set-face-attribute 'small nil :height 0.5)
(insert (propertize "abc" 'face 'small) "\n")

the line height gets shorter even if the tailing newline
doesn't have the face `small'.  This result in that when I
type C-k at the beggining of that line, the line gets
taller, which is counter intuitive.

I think the height of the space glyph for the tailing
newline should be the default frame line height in the above
case, and the line height must be desided by all glyphs
including the tailing space.  Then, to have a short line, we
should do:

(insert (propertize "abc\n" 'face 'small))

In this case, C-k as above doesn't change the line height
because we still have a newline of `small' face.

By the way, it seems that the current code doesn't draw a
hollow cursor correctly.   The bottom line of the rectangle
is not drawn (see the attached image).

---
Ken'ichi HANDA
address@hidden