emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Inefficient code in reftex-index.el


From: Carsten Dominik
Subject: Re: Inefficient code in reftex-index.el
Date: Mon, 6 Jun 2005 16:41:06 +0200


>>>>> "DK" == David Kastrup <address@hidden> writes:

DK> address@hidden (Kim F. Storm) writes:
>> I noticed the following code in reftex-index.el:
>> 
>> (condition-case nil (texmathp) (error nil))))
>> (setq beg (car (match-data))
>> end (nth 1 (match-data)))
>> 
>> Using match-data like that seems inefficient.
>> 
>> I suggtest using match-beginning/match-end instead.

DK> That is not the same: the above will set beg and end to markers,
DK> whereas match-beginning/match-end happen to be integers.  

Yes, indeed markers are needed here.  I will change it like Stafan
proposed it.  Thanks for picking this up, Kim.

I don't understand your ironic reply to Davids email.  Entirely
unnecessary.

- Carsten


--
Carsten Dominik <address@hidden>        \ _ /
Sterrenkundig Instituut "Anton Pannekoek"        |X|               _
Kruislaan 403; NL-1098 SJ Amsterdam             /| |\   _  _     _/ \
phone +31 (20) 525-7477; FAX +31 (20) 525-7484 __|o|___/ ~~ \___/    ~~~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]