Re: "checksum failure after patch" in CVS

[Eli Zaretskii]

> Date: Tue, 5 Jul 2005 01:08:01 +0200
> From: Juanma Barranquero <address@hidden>
> Cc: Emacs Devel <address@hidden>
> 
> On 7/4/05, Jason Rumney <address@hidden> wrote:
> 
> > It's not in binary format in the repository, we deliberately avoid
> > binary format for text files, even when we need to check them in with
> > DOS line ends, because we know that binary format is inconvenient.
> 
> It's a terminology issue. You're right the file is in "text" mode in
> the repository, but when a file is in the repository in text mode with
> CR/LF pairs, in my view it is a binary file masquerading as a text
> one.

It is no more binary than a Unix-style file such as configure.in.

You are, in effect, saying that Emacs is wrong decoding non-Unix EOLs
and treating the result as text by hiding the alien EOL sequences from
the user when it displays the file.  Because if config.bat is a binary
file, we should have visited it with no-conversion.

> I will not say the CVSNT client is right in doing CR/LF ->
> CR/CR/LF, because it obviously is gaffing. But having a CR/LF file in
> the repo as text file is evil, was evil, will forever be evil.

It's not evil because storing it as a binary loses some valuable
features of CVS, like the ability to say "cvs diff", "cvs annotate",
etc.

What _is_ evil is the broken manner in which Windows CVS clients
handle the EOL issue.

> It seems config.bat had LF on the repo and some recent change has
> updated it with CR/LF.

No, config.bat was always stored with DOS EOLs in the Emacs CVS.