Re: Visual cleanup for customize buffers

[Luc Teirlinck]

Kim Storm wrote:

   - click on  whole buffer "Save for Future Sessions" button

      => saves the unset options, but NOT the changed face!!

That is because you hid it, as I explained.

   Really??  The "hide value" button is right there when I look!

   I don't see any code that removes the button -- that's what
   I added.

Yes, I somehow got confused here.  I do not know why I somehow did not
notice the button there.

   I don't see why!  If people want to save indiviual options, use
   the individual State buttons.  If people want to save everything, use
   the whole buffer buttons.

It would definitely be wrong to change the behavior of the whole
buffer buttons with respect to hidden items before the release.  Some
of the few people who use the whole buffer buttons may have come to
rely on it.  Importantly, some Custom internals rely on the whole
buffer buttons not operating on hidden buttons.  For instance, it is
what prevents the whole buffer buttons from recursively descending
into subgroups (which would be a bug with very bad consequences).
Also, if one changed the behavior, it would be very difficult to avoid
introducing a variety of other bugs.  For instance, one would have to
make sure that the whole buffer buttons would not operate on hidden
options that are set outside Custom or are otherwise "rogue", which
would also be a very bad bug.

There has been a previous discussion on Custom where you proposed to
get rid of the State buttons (at least by default).  I believe that
the present discussion shows that this would be a very bad idea
(except maybe in single option buffers).  If it were implemented one
would definitely need to be able to hide options from the whole buffer
buttons.  (And some basic, often needed, things like resetting one
single option to its standard value would get very complex and clumsy.)

I believe that the main problem with the whole buffer buttons (and
related functionality) is that it is too visible to beginning users,
who should not use them (except in single option buffers), because
they are too tricky to use.

Sincerely,

Luc.