[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Fkill_emacs NO_RETURN
From: |
Dan Nicolaescu |
Subject: |
Re: Fkill_emacs NO_RETURN |
Date: |
Mon, 10 Apr 2006 12:27:52 -0700 |
Richard Stallman <address@hidden> writes:
> I deleted the NO_RETURN for Fkill_emacs to avoid hassles.
>
> Marking functions NO_RETURN is desirable from a few points of view:
> -it helps gcc do a better job for the -Wuninitialized warning
>
> Surely Fkill_emacs makes no difference to this.
>
> -it helps lint type tools, it will avoid analyzing the same code over
> and over when a new tool warns about it only to discover there's no
> problem.
>
> Not terribly important.
>
> -it helps code generation: for example by just marking
> `wrong_type_argument' as NO_RETURN the text size decreases from
> 1483168 bytes to 1474080 bytes (ie ~9KB) on my x86 system using
> gcc-4.1
>
> That may be significant for wrong_type_argument, but not for Fkill_emacs.
>
> Perhaps it is worth adding the NO_RETURN for wrong_type_argument.
> It is called a lot more than Fkill_emacs.
The reason I referred to wrong_type_argument is that it has the same
issue as Fkill_emacs: it has a return statement, so marking it as
NO_RETURN would mean having to do something about the return statement.
So please make a decision about marking wrong_type_argument and/or
Fkill_emacs as NO_RETURN.
Re: Fkill_emacs NO_RETURN, Stefan Monnier, 2006/04/09