[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Top posting related changes in the cvs
From: |
Reiner Steib |
Subject: |
Re: Top posting related changes in the cvs |
Date: |
Wed, 04 Apr 2007 00:05:29 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.96 (gnu/linux) |
On Tue, Apr 03 2007, Thien-Thi Nguyen wrote:
> before the fix, yanking would leave the cursor after the yanked
> messages, contrary to the docstring. the fix, to regain concordance w/
> the docstring, involves conditionalizing a previously unconditional call
> to exchange-point-and-mark. i believe the original unconditional call
> was correct (necessary) prior to another change:
>
> 2005-08-01 Katsumi Yamaoka <address@hidden>
>
> * gnus-uu.el (gnus-uu-save-article): Use insert-buffer-substring
> instead of insert-buffer.
>
> * message.el (message-yank-original): Ditto; set the mark at the
> end of the yanked message.
>
> insert-buffer-substring inserts before point, while insert-buffer
> inserts after point. my analysis is that the exchange-point-and-mark
> relied on insert-buffer's behavior, and thus became incorrect after the
> 2005-08-01 change, since point and mark were already in the correct
> order.
>
> my fix (to conditionalize the call) removes the direct dependency so
> that the desired ending position of point will be as documented for
> whatever function is used (now or in the future) to do the insert, as
> long as the inserted text is bracketed by point and mark.
>
> an alternative fix that is less robust against future changes is to rely
> on the behavior of insert-buffer-substring and simply remove the call to
> exchange-point-and-mark. then we can chase this bug again later for
> hours of fun...
[...]
> i think the behavior, leaving point between the citation and the yanked
> text, is nice. i was happy to read about it in the docstring. it seems
> whoever wrote the original (concording) code+docstring was thoughtful.
I gather that you refer to an interactive call of
`message-yank-original' (C-c C-y) after doing a reply/followup without
citing the original (using `r'/`f'). However, when using `R'/`F', I
don't get this behavior anymore: Point is _below_ the quote, which is
wrong.
Bye, Reiner.
--
,,,
(o o)
---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/
- Re: Top posting related changes in the cvs, Reiner Steib, 2007/04/03
- Re: Top posting related changes in the cvs, Thien-Thi Nguyen, 2007/04/03
- Re: Top posting related changes in the cvs,
Reiner Steib <=
- Re: Top posting related changes in the cvs, Thien-Thi Nguyen, 2007/04/03
- Re: Top posting related changes in the cvs, Gabor Z. Papp, 2007/04/03
- Re: Top posting related changes in the cvs, Katsumi Yamaoka, 2007/04/09
- Re: Top posting related changes in the cvs, Thien-Thi Nguyen, 2007/04/09
- Re: Top posting related changes in the cvs, Reiner Steib, 2007/04/09
- Re: Top posting related changes in the cvs, Katsumi Yamaoka, 2007/04/09