Re: EMACS_22_BASE: Crash after creating a new frame, gtk_toolbar_set_icon_size?

[Jan Djärv]

Reiner Steib skrev:
> report-emacs-bug wrote:
> 
>> Please describe exactly what actions triggered the bug
>> and the precise symptoms of the bug:
> 
> Emacs crashed after `M-x w3m RET' which makes a new frame in my setup.
> 
> Emacs is from the EMACS_22_BASE, cvs-updated, bootstrapped and
> compiled yesterday with GTK:
> 
>> In GNU Emacs 22.1.50.1 (i686-pc-linux-gnu, GTK+ Version 2.10.6)
>>  of 2007-08-04 on viandante
>> Windowing system distributor `The X.Org Foundation', version 11.0.70199902
>> configured using `configure  '--prefix=/import/xtra/emacs/RC' '--with-gtk' 
>> '--exec-prefix=/import/xtra/emacs/RC-i686''
> 
>> If Emacs crashed, and you have the Emacs process in the gdb debugger,
>> please include the output from the following gdb commands:
>>     `bt full' and `xbacktrace'.
>> If you would like to further debug the crash, please read the file
>> [...]/emacs/cvs-EMACS_22_BASE/emacs/etc/DEBUG for instructions.
> 

It looks like some picture file for the tool bar didn't load correctly and we
loose track of where we are in the tool bar.  Can you try the attached patch?

Thanks,

        Jan D.

Index: src/gtkutil.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/gtkutil.c,v
retrieving revision 1.106.2.2
diff -c -c -r1.106.2.2 gtkutil.c
*** src/gtkutil.c       25 Jul 2007 05:15:51 -0000      1.106.2.2
--- src/gtkutil.c       7 Aug 2007 11:15:08 -0000
***************
*** 3799,3805 ****
                gtk_container_add (GTK_CONTAINER (weventbox), wbutton);
                ti = gtk_tool_item_new ();
                gtk_container_add (GTK_CONTAINER (ti), weventbox);
!               gtk_toolbar_insert (GTK_TOOLBAR (x->toolbar_widget), ti, i);
              }
            continue;
          }
--- 3799,3805 ----
                gtk_container_add (GTK_CONTAINER (weventbox), wbutton);
                ti = gtk_tool_item_new ();
                gtk_container_add (GTK_CONTAINER (ti), weventbox);
!               gtk_toolbar_insert (GTK_TOOLBAR (x->toolbar_widget), ti, -1);
              }
            continue;
          }
***************
*** 3816,3822 ****
            gtk_container_add (GTK_CONTAINER (weventbox), wbutton);
            ti = gtk_tool_item_new ();
            gtk_container_add (GTK_CONTAINER (ti), weventbox);
!           gtk_toolbar_insert (GTK_TOOLBAR (x->toolbar_widget), ti, i);
  
  
            /* The EMACS_INT cast avoids a warning. */
--- 3816,3822 ----
            gtk_container_add (GTK_CONTAINER (weventbox), wbutton);
            ti = gtk_tool_item_new ();
            gtk_container_add (GTK_CONTAINER (ti), weventbox);
!           gtk_toolbar_insert (GTK_TOOLBAR (x->toolbar_widget), ti, -1);
  
  
            /* The EMACS_INT cast avoids a warning. */