[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Installation of bubbles.el
From: |
Thien-Thi Nguyen |
Subject: |
Re: Installation of bubbles.el |
Date: |
Mon, 27 Aug 2007 21:02:43 +0200 |
User-agent: |
Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) |
() Ulf Jasper <address@hidden>
() Mon, 27 Aug 2007 20:19:40 +0200
Would somebody please install bubbles.el?
i have installed it as lisp/play/bubbles.el, and
made some slight modifications. two items remain:
- please write a blurb for NEWS
- i noticed some `define-key' forms at top-level.
the pattern is like so:
(defvar MAP INIT)
(define-key MAP ...)
(define-key MAP ...)
(define-key MAP ...) ...
i think it would be a good idea to move the defvars to the
beginning of the file, w/ value nil, and also consolidate
the define-key forms using the idiom:
(unless MAP
(let ((m INIT))
(define-key m ...) ...))
other ways: mapc define-key over a list, etc.
other than that, looks good! i was glad to install it.
thi