Re: Installation of bubbles.el

[Stefan Monnier]

>  - i noticed some `define-key' forms at top-level.
>    the pattern is like so:
>      (defvar MAP INIT)
>      (define-key MAP ...)
>      (define-key MAP ...)
>      (define-key MAP ...) ...

>    i think it would be a good idea to move the defvars to the
>    beginning of the file, w/ value nil, and also consolidate
>    the define-key forms using the idiom:
>      (unless MAP
>        (let ((m INIT))
>          (define-key m ...) ...))

Better yet: move the define-keys directly inside the defvar.


        Stefan