Re: 23.0.50; face-problems with multy-tty

[Johan Bockgård]

Dan Nicolaescu <address@hidden> writes:

> Here a simplified test case:
>
> set TERM to vt100 (so that the frame background is considered to be 'dark by 
> default)
>
> Save this as test.el: 
> (custom-set-faces
>  '(font-lock-string-face ((((class color) (min-colors 88) (background light)) 
> (:foreground "RosyBrown4")))))
>
> run:
> emacs -nw -q -l test.el 
> M-x server-start RET
>
> Now run:
>
> emacsclient 
>
> look in the emacsclient frame at font-lock-string face, the foreground
> will be nil.
>
> Somehow the faces are not initialized correctly. My suspicion is that
> when the faces are computed the background mode might no be set
> correctly.
>
> Can somebody that knows how these things are supposed to work take a
> look ?

Is this the right fix?

--- cus-face.el 29 Aug 2007 16:12:24 +0200      1.48
+++ cus-face.el 07 Sep 2007 02:55:49 +0200      
@@ -342,7 +342,8 @@
                (unless (facep face)
                  (make-empty-face face))
                (put face 'face-comment comment)
-               (face-spec-set face spec))
+               (dolist (frame (frame-list))
+                 (face-spec-set face spec frame)))
            (setq args (cdr args)))
        ;; Old format, a plist of FACE SPEC pairs.
        (let ((face (nth 0 args))


-- 
Johan Bockgård