Re: svn icons in the toolbar

[Stephen Berman]

An update:

On Wed, 19 Sep 2007 23:22:58 +0200 Stephen Berman
<address@hidden> wrote: 

> On Wed, 19 Sep 2007 08:26:24 +0200 Jan Djärv <address@hidden> wrote:
>
>> Stephen Berman skrev:
>>> On Sun, 02 Sep 2007 19:46:52 +0200 Jan Djärv <address@hidden> wrote:
>>>
>>>> Jan Djärv skrev:
>>>>> Leo skrev:
>>>>>> However have you noticed the 3rd icon on the tool-bar is still from the
>>>>>> old xpm images. A new one could look like this:
>>>>>>
>>>>> Yes, I've noticed.  That is because I found no suitable stock icon for it.
>>>>> Does the icon you attached have a stock name?  Where is it from?
>>>>>
>>>> I think it is the named icon system-file-manager.  I added that one.
>>>
>>> I'm running GNU Emacs 23.0.50.3 (i686-pc-linux-gnu, GTK+ Version
>>> 2.10.6) of 2007-09-17 on escher under KDE 3.5.7.  The defcustom
>>> x-gtk-stock-map from x-win.el contains this: ("etc/images/diropen"
>>> . "n:system-file-manager").  Nevertheless, the relevant tool bars all
>>> have diropen.xpm from etc/images rather than system-file-manager.png.
>>> My system has the following system-file-manager icons:
>>>
>>>     /opt/gnome/share/icons/gnome/16x16/apps/system-file-manager.png
>>>     /opt/gnome/share/icons/gnome/22x22/apps/system-file-manager.png
>>>     /opt/gnome/share/icons/gnome/24x24/apps/system-file-manager.png
>>>     /opt/gnome/share/icons/gnome/32x32/apps/system-file-manager.png
>>>     /usr/share/icons/Tango/128x128/apps/system-file-manager.png
>>>     /usr/share/icons/Tango/16x16/apps/system-file-manager.png
>>>     /usr/share/icons/Tango/22x22/apps/system-file-manager.png
>>>     /usr/share/icons/Tango/24x24/apps/system-file-manager.png
>>>     /usr/share/icons/Tango/32x32/apps/system-file-manager.png
>>>     /usr/share/icons/Tango/48x48/apps/system-file-manager.png
>>>     /usr/share/icons/Tango/64x64/apps/system-file-manager.png
>>>     /usr/share/icons/Tango/72x72/apps/system-file-manager.png
>>>     /usr/share/icons/Tango/96x96/apps/system-file-manager.png
>>>
>>> When I run Emacs under Gnome, system-file-manager.png is used.  Note
>>> that the tool bars do display the available Gnome stock icons under
>>> KDE, it's just the named icon that isn't used.
>>>
>>
>> I don't think named icons work under anything else than Gnome.  The
>> theme is set in XSETTINGS and that is maintained by the gnome settings
>> daemon.  The Gtk+ stock icons however, are hardcoded in Gtk+.
>
> I forgot that I am using the gtk-qt engine, which "allows GTK
> applications to use Qt widget styles", including tool bar icons.  The
> icons I see are actually KDE icons from
> /opt/kde3/share/icons/crystalsvg/32x32/actions.  I assume gtk-qt maps
> the Gnome stock icons to corresponding KDE icons of the selected
> theme.  I couldn't find an icon in the crystal theme corresponding to
> system-file-manager, but it may just be that gtk-qt does not handle
> named Gnome icons.
>
> Steve Berman

I recently installed openSUSE 10.3 and there I do see the named
system-file-manager icon in the tool bar under KDE.  I would guess this
is due to an updated gtk-qt engine, but I haven't tried the latest
gtk-qt engine in openSUSE 10.2.  I did look at gtk-qt source and was
surprised to find no reference to system-file-manager, but maybe it's
referred to differently or I just don't understand how the mapping is
done.  Whatever, at least I see the icon now.  Hopefully I'll still be
able to after the bug that the code to handle named icons introduced
(see my post about Emacs aborting with a detached GTK+ tool bar) is
fixed!

Steve Berman