emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch] vc-git-dired-state-info buglet


From: Thien-Thi Nguyen
Subject: [patch] vc-git-dired-state-info buglet
Date: Fri, 23 Nov 2007 13:09:21 +0100

i think `vc-git-dired-state-info' should call `vc-git-state'
instead of `vc-state'.  here is a recipe: create dir `test',
put it under git version control system, add and commit some
files, then modify a subset of the files.  then do:

C-x v d test RET  ; => empty because no files "locked"
v t               ; => toggle terse mode

before the patch, no files are shown w/ "(modified)" status.
after the patch, some are shown, as i expected.

i wonder if my expectation is incorrect.  comments?

thi


________________________________________________________
*** vc-git.el   20 Oct 2007 01:28:35 -0000      1.25
--- vc-git.el   23 Nov 2007 12:02:57 -0000
***************
*** 205,211 ****
  
  (defun vc-git-dired-state-info (file)
    "Git-specific version of `vc-dired-state-info'."
!   (let ((git-state (vc-state file)))
      (if (eq git-state 'edited)
        "(modified)"
        ;; fall back to the default VC representation
--- 205,211 ----
  
  (defun vc-git-dired-state-info (file)
    "Git-specific version of `vc-dired-state-info'."
!   (let ((git-state (vc-git-state file)))
      (if (eq git-state 'edited)
        "(modified)"
        ;; fall back to the default VC representation





reply via email to

[Prev in Thread] Current Thread [Next in Thread]