emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: easy-menu subtlety


From: Andreas Schwab
Subject: Re: easy-menu subtlety
Date: Wed, 20 Feb 2008 17:32:56 +0100
User-agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.1 (gnu/linux)

Dan Nicolaescu <address@hidden> writes:

> The last 3 lines of this code sequence in lisp/progmodes/verilog-mode.el:
>
>     ("Move"
>      ,(if (featurep 'xemacs)
>           (progn 
>             ["Beginning of function"            verilog-beg-of-defun t]
>             ["End of function"                  verilog-end-of-defun t]
>             ["Mark function"                    verilog-mark-defun t])
>         ["Beginning of function"                beginning-of-defun t]
>         ["End of function"                      end-of-defun t]
>         ["Mark function"                        mark-defun t])

That looks completely bogus to me.  The result of the evaluation of the
form is a single vector, with the other two just thrown away.  I think
the intention was to write this:

    ("Move"
     ,@(if (featurep 'xemacs)
           '(["Beginning of function"           verilog-beg-of-defun t]
             ["End of function"                 verilog-end-of-defun t]
             ["Mark function"                   verilog-mark-defun t])
        '(["Beginning of function"              beginning-of-defun t]
          ["End of function"                    end-of-defun t]
          ["Mark function"                      mark-defun t]))

Andreas.

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]