[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] XCloseDisplay already calls XrmDestroyDatabase
From: |
Stefan Monnier |
Subject: |
Re: [PATCH] XCloseDisplay already calls XrmDestroyDatabase |
Date: |
Sun, 17 May 2009 17:40:05 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) |
> I confirmed that the libX11 shipped with Mac OS X 10.4 doesn't contain
> the above change.
> http://www.opensource.apple.com/source/X11/X11-0.46.4/xc/lib/X11/
> If we remove the XrmDestroyDatabase call unconditionally, then it
> causes a memory leak when used with a newer libX11. But that would be
> better than crashing when used with an older one.
OTOH, it's better to work correctly with the new code than with the old
code (better be future-proof than past-proof). Seeing how Mac OS X 10.5
has been out for a while now, I expect most users of Emacs-23 will run
with code that would tend to leak rather than with code that
would tend to crash.
So, I'd rather just free XrmDestroyDatabase and add a note in PROBLEMS
that with older releases of libX11 there may be crashes when closing
the display.
Stefan