[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] XCloseDisplay already calls XrmDestroyDatabase
|
From: |
Stefan Monnier |
|
Subject: |
Re: [PATCH] XCloseDisplay already calls XrmDestroyDatabase |
|
Date: |
Sun, 17 May 2009 17:40:50 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.93 (gnu/linux) |
>> If we remove the XrmDestroyDatabase call unconditionally, then it
>> causes a memory leak when used with a newer libX11. But that would
>> be better than crashing when used with an older one.
> Or maybe we can dissociate the resource database from the display
> before closing it.
> #ifdef HAVE_XRMSETDATABASE
> XrmSetDatabase (dpyinfo->display, NULL);
> #else
dpyinfo-> display->db = NULL;
> #endif
> Then we can ignore the difference of libX11 at least for normal close.
Sounds OK as well.
Stefan