Re: git push/pull

[Fabian Ezequiel Gallina]

2009/12/6 Andreas Schwab <address@hidden>:
> Fabian Ezequiel Gallina <address@hidden> writes:
>
>> +     (setq available-repos
>> +           (let ((table (list ".")))
>> +             (with-temp-buffer
>> +               (vc-git-command t nil nil "for-each-ref" 
>> "--format=%(refname)")
>> +               (goto-char (point-min))
>> +               (while (re-search-forward "^refs/remotes/\\([^/]+\\).*$" nil 
>> t)
>> +                 (push (match-string 1) table)))
>> +             table))
>
> This is still wrong.
>
> Andreas.
>
> --
> Andreas Schwab, address@hidden
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
> "And now for something completely different."
>

Andreas, I'm not sure about that.

That completion part is for the <repository> argument in a basic git
push/pull command. AFAIK repository could be remote name and a remote
name cannot contain "/"[0], this is different on the refspec part
which can be have the form <remote>/<branch>.

After I saw you previous email stating this was wrong I took a deeper
look at the completion and at the moment the completions you have
available in the minibuffer are the same you would have in the
terminal. Anyways with this I'm not saying it cannot be improved.


[0] http://repo.or.cz/w/git.git/blob/master:/remote.c#l671


Regards,
-- 
Fabián E. Gallina
http://www.from-the-cloud.com