emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Display performance degradation


From: Andreas Schwab
Subject: Re: Display performance degradation
Date: Sat, 19 Dec 2009 11:00:56 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.90 (gnu/linux)

YAMAMOTO Mitsuharu <address@hidden> writes:

>   4490                    if (XINT (XCAR (val)) == 0)
>   4491                      {
>   4492                        font_clear_cache (f, XCAR (val), 
> driver_list->driver);
>   4493                        XSETCDR (cache, XCDR (val));
>   4494                      }
>   4495                  }
>
> At line 4490, XCAR (val) is expected to be of type Lisp integer.  But
> it is also passed to font_clear_cache at line 4492, which seems to
> expect the value of `val' as of line 4488 rather than the one assigned
> at line 4489.

If the condition is ever true then Emacs crashes.  I've checked in a
fix.  But then, I don't think this function is ever more than a no-op
anyway, since as soon as NUM-FRAMES becomes zero the cache is cleared
automatically anyway.

Andreas.

-- 
Andreas Schwab, address@hidden
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]