emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.


From: Jan Djärv
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100503: Fix config.h includes.
Date: Wed, 02 Jun 2010 21:08:49 +0200
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5



Stephen J. Turnbull skrev 2010-06-02 18.55:
Stefan Monnier writes:
  >  >>  >    * src/dbusbind.c: Use #include<config.h>  instead of "config.h" 
as all
  >  >>  >    other files do.
  >  >>  I understand teh desire to make it uniform, but why choose to
  >  >>  standardize on<config.h>  rather than "config.h"?
  >  >  VPATH.
  >
  >  I don't see how that relates.  VPATH seems to be a make-only feature,
  >  whereas we're talking about C code.

Specifically, people who build both in-tree and out-of-tree.

If you do that, VPATH/--srcdir can break because you have multiple
config.h on the #include search path, and the one in-tree always wins
if you use #include "config.h".

I get that once in a while, but if you are building out of the tree you shouldn't have any config.h in-tree. Unless you mix in and out of tree builds.

        Jan D.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]