emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add notifications.el


From: Davis Herring
Subject: Re: [PATCH] Add notifications.el
Date: Mon, 7 Jun 2010 15:28:05 -0700 (PDT)
User-agent: SquirrelMail/1.4.8-5.el5_4.10.lanl1

>>> + :app-icon       The notification icon.
>>
>> If not given, you could apply a default value. A good value might be
>>
>> (expand-file-name "images/icons/hicolor/scalable/apps/emacs.svg"
>> data-directory)
>
> Good idea, thanks. Added.

You should be careful to allow the caller to specifically request no icon;
I see from the code that :app-icon nil won't do that; perhaps :app-icon ""
would?

Davis

-- 
This product is sold by volume, not by mass.  If it appears too dense or
too sparse, it is because mass-energy conversion has occurred during
shipping.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]