Re: Emacs core TLS support

[Ted Zlatanov]

On Mon, 27 Sep 2010 16:40:09 +0200 Lars Magne Ingebrigtsen <address@hidden> 
wrote: 

LMI> Lars Magne Ingebrigtsen <address@hidden> writes:
>> If I return Qt when gnutls_handshake() returns zero, then I get the
>> Gmail IMAP greeting, which I think it works.
>> 
>> I'll clean it up and see whether that really fixed this...

LMI> I've checked in the changes, since it works a bit better now than
LMI> before.  Previously, it would try to do the handshake in a loop after
LMI> completing it, and that obviously doesn't work.

Hmm, GNUTLS_E_SUCCESS is 0 by definition.  But you say in your patch:

-  if (GNUTLS_E_SUCCESS == ret)
+  if (GNUTLS_E_SUCCESS == ret || ret == 0)
   {
     /* here we're finally done.  */
     GNUTLS_INITSTAGE (proc) = GNUTLS_STAGE_READY;
+    return Qt;
   }
 
   return gnutls_make_error (ret);

gnutls_make_error returns Qt when the error is GNUTLS_E_SUCCESS.  So
none of this should be necessary.  Similarly the change to gnutls.el:

-      (while (and (not (gnutls-error-fatalp ret))
+      (while (and (not (eq ret t))
+                 (not (gnutls-error-fatalp ret))

If you do (gnutls-error-fatalp t) you'll get nil, so again that
shouldn't have been necessary.  Am I missing something?

Ted