Re: [PATCH] erc-track erases the modeline when new buffers are created

[Michael Olson]

Looks good to me.

On Fri, Aug 13, 2010 at 3:57 PM, Antoine Levitt
<address@hidden> wrote:
> When a new ERC buffer is created (for instance, a query) while erc-track
> displays information in the mode line, the information is removed. I
> tracked the bug down to an initialisation of
> erc-modified-channels-object each time erc-track-mode is activated (ie,
> each time an ERC buffer is created). This is useless because the
> variable is initialised at load time with (defvar).
>
> This patch simply removes the extra initialisation. I tested it, it
> works for me and I don't see any potential bugs the removal might cause.
>
> Antoine Levitt
>
> === modified file 'lisp/erc/erc-track.el'
> --- lisp/erc/erc-track.el       2010-01-13 08:35:10 +0000
> +++ lisp/erc/erc-track.el       2010-08-13 22:47:20 +0000
> @@ -649,7 +649,6 @@
>           (add-hook 'erc-send-completed-hook 'erc-user-is-active)
>           (add-hook 'erc-server-001-functions 'erc-user-is-active))
>        (erc-track-add-to-mode-line erc-track-position-in-mode-line)
> -       (setq erc-modified-channels-object (erc-modified-channels-object nil))
>        (erc-update-mode-line)
>        (if (featurep 'xemacs)
>           (defadvice switch-to-buffer (after erc-update (&rest args) activate)
>
>
>



-- 
Michael Olson  |  http://mwolson.org/