emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Any objection to adding completing-read-function?


From: Stefan Monnier
Subject: Re: Any objection to adding completing-read-function?
Date: Wed, 22 Jun 2011 17:19:13 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

>> The C code checks (memq minibuffer-completing-file-name '(nil
>> lambda)) instead.  Are you sure your code is correct, and if so why?
> The value 'lambda is not documented anywhere. What's its meaning?

It's an internal hack and should mostly be invisible to the rest of the
Lisp code.  It's explained in a comment in minibuf.c (search for
Qlambda).
Passing an initialization-function to read_minibuf (e.g. via the
initial-input arg) would make it possible to get rid of this hack, BTW.

BTW, your patch looks OK now, so if your tests indicate that it works
correctly, feel free to install it.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]