[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: /etc/TODO: define-minor-mode & minor-mode-list
From: |
Stefan Monnier |
Subject: |
Re: /etc/TODO: define-minor-mode & minor-mode-list |
Date: |
Thu, 02 Feb 2012 13:40:40 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) |
>>> Also is this todo considered todone?
>> Largely, yes. I did this during the Emacs-24 development (which lead to
>> the addition of the `:variable' argument). My methodology to find
>> potential minor modes was to grep for something like "defun.*-mode
>> ([^)]" since traditionally minor modes take an argument, whereas major
>> modes don't. There are a few cases I found which I haven't converted,
>> usually because the conversion was less straightforward so I left it
>> for later. These are: orgstruct++-mode, tcl-auto-fill-mode,
>> vhdl-hs-minor-mode, speedbar-frame-mode, reftex-isearch-minor-mode,
>> type-break-mode.
>> There are probably other candidates, of course.
> I searched for more but I've probably unearthed more false positives
> than anything else. I'll hopefully have at least one patch by the end of
> the week.
Just to give you an idea of the kinds of problems you might have to deal
with: changing orgstruct++-mode to use define-minor-mode should be
fairly easy with the new `:variable' argument, but I suspect that the
Org guys won't be happy with this since they want their code to work
under Emacs-23 as well.
Stefan