emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tr


From: Stefan Monnier
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-24 r111088: * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
Date: Thu, 03 Jan 2013 11:28:32 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

>>> * net/tramp-sh.el (tramp-set-file-uid-gid): Convert UID and GID to
>>> integers, if they are real numbers.  (Bug#13282)
>> Why is that TRT?  Or more specifically, why do we get floats here?
>> They should only happen when the number is too large to be represented
>> as a fixnum.

> That's exactly the reason. See 
> <http://thread.gmane.org/gmane.emacs.tramp/8022/focus=8024>.

But I don't see anything in the patch which checks that `round' returned
the right value (i.e. we now always return integers and never floats,
even if the value is too large to be represented as an integer).


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]