Re: 24.2.92 fix [Re: Crash caused by insert-file-contents, both trunk (bzr 111532) and 24.2.92 affected]

[Dmitry Antipov]

On 01/22/2013 05:54 AM, Glenn Morris wrote:

> Sorry, I missed the context.
> What problem is this fixing?

Crash caused by insert-file-contents from non-regular file
(http://lists.gnu.org/archive/html/emacs-devel/2013-01/msg00324.html
and below in thread).

> How is it triggered?

On GNU/Linux, (insert-file-contents "XXX") where XXX is a character
or block device file (/dev/kmsg, /dev/sda, whatever else).

> What version of Emacs did the problem first appear in?

I found that both in 24.2.92 and trunk bzr 111532, and suspect
a long-standing bug from 2001 or so.

> How safe do you think the fix is?

I did a quite representative testing against a few character and
block devices found on my system, and the crash is gone. So I
consider it as good enough until otherwise proved :-).

Dmitry