emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Any exceptions for the 15-line rule?


From: Dmitry Gutov
Subject: Re: Any exceptions for the 15-line rule?
Date: Wed, 01 May 2013 09:13:51 +0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt)

Here's another case, with even more trivial code that for the most part
just changes a few constants to update them for spec changes.

https://github.com/mooz/js2-mode/pull/101
https://github.com/mooz/js2-mode/pull/100

(add .diff at the end of each URL to see the plain diff)

Unfortunately, I accidentally complicated #101 by also suggesting a
trivial code transformation: extracting one statement into a function,
which the reporter has promptly performed.

On the face of it, both patches exceed 15 lines in total, but I hesitate
to ask for CA over something this simple (this would also mean delaying
the next merge from Git to elpa for however long that takes).

Any suggestions?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]