emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] frame.c: focus hooks


From: Stefan Monnier
Subject: Re: [PATCH] frame.c: focus hooks
Date: Tue, 19 Nov 2013 22:16:41 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

> These frame focus hooks are closely related to the select-window-hook
> that was proposed and ultimately rejected a few years back[0].  Would
> such a hook be accepted now if its documentation were to contain a
> similar warning?

Personally, I think such a hook is not in itself a problem.  But I also
think it's ill-advised.  The main reason is that select-window is an
operation used internally, so it can be called many times within
a single command, even if the command might end up "staying in the same
window".

A pre/post-command-hook that compares selected-window with the previous one
will provide a behavior closer to what users want, I think.
Of course, it could still be called select-window-hook, tho that name
would be a bit misleading.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]