emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Emacs pretest -- electric-pair-mode change


From: Stefan Monnier
Subject: Re: Emacs pretest -- electric-pair-mode change
Date: Fri, 04 Apr 2014 08:53:23 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux)

> OK so something like this is acceptable for trunk & 24.4?

Looks OK, yes.

> (defun electric-pair--unbalanced-strings-p (char)
>   "Return non-nil if there are unbalanced strings started by CHAR"

Please terminate with ".".

>   (let* ((selector-ppss (syntax-ppss))
>          (relevant-ppss (save-excursion
>                           (if (nth 4 selector-ppss) ; in comment
>                               (let ((comment-start
>                                      (progn
>                                        (goto-char (line-beginning-position))

Huh?  Shouldn't this use (nth 8 (syntax-ppss))?


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]