Re: Changes in frame/window code

[Eli Zaretskii]

> Date: Tue, 29 Jul 2014 12:41:02 +0300
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden, address@hidden
> 
> >  > You need to reverse the meaning of START and END for the R2L case:
> >  >
> >  >     end = whole - w->hscroll * FRAME_COLUMN_WIDTH (WINDOW_XFRAME (w));
> >  >     start = end - box_width;
> >  >
> >  > (Note that current-bidi-paragraph-direction returns the results at
> >  > buffer's point, so you will need to temporarily go to the window's
> >  > point marker.)
> > 
> > As soon as you have some spare time (I know you never do) please try it.
> 
> I can only try this on MS-Windows.

Btw, I'm not sure I follow the logic of this snippet:


      /* The following is needed to ensure that if after maximizing a
         window we get hscroll > 0, we can still drag the thumb to the
         left.  */
      whole = max (whole, w->hscroll + box_width);
      whole = max (whole, end - start);

First, hscroll is in columns, while box_width is in pixels, so adding
them sounds incorrect.

Second, what problem does this try to solve, and why would this
double-maxing solve it?

And third, since end - start is exactly equal to box_width, why do you
need the second max?  What am I missing?