Re: [Emacs-diffs] scratch/check-declare e7e278c 1/2: check-declare.el (check-declare-ext-errors): New defcustom.

[Oleh Krehel]

Stefan Monnier <address@hidden> writes:

>> +(defgroup check-declare nil
>> +  "Check declare-function statements"
>> +  :group 'tools)
>
> I think you need a "." at the end of these docstrings.  C-u M-x
> checkdoc-current-buffer might flag those things (along with others with
> which I don't always agree ;-)
>
>> +(defcustom check-declare-ext-errors nil
>> +  "When non-nil, warn abount functions not found in :ext"
>> +  :group 'check-declare)
>
> This :group is redundant.  OTOH you need a ":type 'boolean".

OK, fixed.

>
>> +  (cl-letf ((warning-prefix-function
>
> Why cl-letf?

Because it works. Would you suggest something else?

Oleh