emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files


From: Oleh Krehel
Subject: Re: master 6d6bf46 2/2: Make dired-do-compress work for *.tar.gz files
Date: Wed, 21 Oct 2015 17:04:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

>>     (define-key map "c" 'dired-compress)
>> 
>> The proposed key isn't bound by default. Is that OK?
>
> Sounds OK to me, but maybe wait for a while for others to speak up.

I've committed this new command, turns out `dired-compress' was already
taken:

    (define-key map "c" 'dired-do-compress-to)

Please check if I didn't end up doing something strange. A few points:

1. Is using `cl-find-if' OK in dired.el (I assume this should be fine).

2. There's some autoload regeneration rule that modifies dired.el when
dired-aux.el is modified. Should that autoload be committed together
with a change?

3. Other recipes can be added to `dired-compress-files-alist'. I just
added the two that I'm familiar with. It also needs to be checked if
"zip" typically supports --filesync.

4. I've added NEWS entries, but I forgot how the +++/---/ markers
work. Where is that info? I can document the changes in the manual once
we agree that the change is fine.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]