Re: The poor state of documentation of pcase like things.

[Daniel Colascione]

On 01/01/2016 10:39 AM, David Kastrup wrote:
> John Wiegley <address@hidden> writes:
> 
>>>>>>> Eli Zaretskii <address@hidden> writes:
>>
>>>      (pcase skip
>>>        (`nil nil)
>>>        (`0 t)
>>>        (_ (setq i (+ i skip -1)) (funcall get-next-frame)))))))
>>
>> (cond ((null skip))
>>       ((eq skip 0) t)
>>       (t (setq i (+ i skip -1)) 
>>          (funcall get-next-frame)))
>>
>> Not much difference.
> 
> If skip is nil, the first returns probably nil and the second t.  One
> could probably do
> 
> (and skip
>      (or (eql skip 0)
>          (setq ...)))
> 
> I'm not fond of eq for numeric comparisons: that's an Elispism.

That's true, but I think it's too pervasive to change now, so why fight it?

signature.asc
Description: OpenPGP digital signature