Re: master 0883e98 1/3: New functions for getting and setting image properties

[Michael Heerdegen]

Michael Heerdegen <address@hidden> writes:

> Looks ok.  Nitpick: according to the doc of `gv-define-simple-setter',
> to "preserve the semantics of setf" `image--set-property' should either
> return the VALUE.  Or use
>
>   (declare (gv-setter image--set-property t))
>                                           ^
>
> Hmm, this DTRT, though it's not documented in
>
>  (info "(elisp) Declare Form")
>
> Will file a bug report...


Done - see bug#22766: 25.0.91; (info "(elisp) Declare Form"): gv-setter:
mention FIX-RETURN arg

Stefan suggests to change `image--set-property' to return the VALUE
instead of using the undocumented optional second arg of the gv-setter
declare form.


Michael.