Re: Upcoming seq.el version problem with the Emacs release

[Nicolas Petton]

Stefan Monnier <address@hidden> writes:

>> The problem is that seq.el (in Emacs) uses `pcase-defmacro', which does
>> not exist in Emacs 24.5.  When byte-compiling the file, we get warnings
>> as the byte compiler will think that `pcase-defmacro' is a function.
>
> Is that really the only problem?

We'd get byte-compilation warnings.  Maybe that's something we can live
with, but since it's easy enough to fix, now that I know how to do it,
I'd rather make sure that we don't get any warning in Emacs 24.5.

> I thought the main problem was that GNU ELPA's seq.el can't use
> cl-defgeneric since GNU-ELPA's cl-generic can only dispatch on
> EIEIO types.

No, that's a limitation I'm ok with.

> As for preventing byte-compilation, yes indeed you can and I've done
> that a few times recently.  See for example dts--using-macro in the
> dts-mode package (in GNU ELPA).
> See also TeX--if-macro-fboundp in auctex's tex.el.

Thanks for the pointers!

Nico

signature.asc
Description: PGP signature