[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Unbalanced change hooks (part 2)
From: |
Noam Postavsky |
Subject: |
Re: Unbalanced change hooks (part 2) |
Date: |
Sun, 31 Jul 2016 15:20:31 -0400 |
On Sun, Jul 31, 2016 at 2:11 PM, Eli Zaretskii <address@hidden> wrote:
>> 2. Where a call to signal_buffer_change is within an "if (prepare) ..."
>> construct, move it to after that construct, so that
>>
>> if (prepare)
>> {
>> prepare_to_modify_buffer (...);
>> signal_after_change (...);
>> }
>>
>> would become
>>
>> if (prepare)
>> prepare_to_modify_buffer (...);
>> signal_after_change (...);
>
> See, that's the part that scares me. You are proposing to run code
> where we didn't run it before. Did you look at what
> signal_after_change does? It doesn't just call
> after-change-functions, it does much more.
Doesn't look like that much more to me. In addtion to
after-change-functions, it also calls overlay and text property
modification hooks. I don't see anything else.
- Unbalanced change hooks (part 2), Alan Mackenzie, 2016/07/31
- Re: Unbalanced change hooks (part 2), Noam Postavsky, 2016/07/31
- Re: Unbalanced change hooks (part 2), Eli Zaretskii, 2016/07/31
- Re: Unbalanced change hooks (part 2), Stefan Monnier, 2016/07/31
- Re: Unbalanced change hooks (part 2), Eli Zaretskii, 2016/07/31
- Re: Unbalanced change hooks (part 2), Stefan Monnier, 2016/07/31
- Re: Unbalanced change hooks (part 2), Alan Mackenzie, 2016/07/31
- Re: Unbalanced change hooks (part 2), Eli Zaretskii, 2016/07/31