Re: [Emacs-diffs] emacs-25 bc55a57: * lisp/menu-bar.el (kill-this-buffer): Doc fix. (Bug#26466)

[Eli Zaretskii]

> From: Stefan Monnier <address@hidden>
> Date: Mon, 17 Apr 2017 08:14:58 -0400
> 
> >> By this measure, we can stop hacking on Emacs,
> > Not hacking, only bike-shedding.
> 
> To me bike-shedding means that it's only an aesthetic issue, but in this
> case the ugliness has enough real consequences that you felt compelled
> to document them via:

The request for documenting the subtlety was voiced more than once
over the years, and I saw no reason not to act on that.  We document
similar limitations and subtleties all over the place, so there's
nothing extraordinary in this case.

And I see no ugliness here, so if it exists, it must be minor.  Thus
it makes very little sense to me to insist on changing code that
existed for several years because of some ugliness on whose existence
we cannot even agree.

> My patch (as fixed by Martin) fixes the problem instead of documenting
> the resulting quirks.

I think your patch involves some real, though perhaps minor, risk of
breaking some code out there, and I don't think that risk is
justified, given the (un)importance of the issue.