Re: [Emacs-diffs] master f57c710: Use a named function for global minor mode turn-on argument

[Mark Oteiza]

On 24/07/17 at 08:25pm, Mark Oteiza wrote:
> On 24/07/17 at 12:56pm, Glenn Morris wrote:
> > Stefan Monnier wrote:
> >
> > > > ;;;###autoload
> > > > +(defun turn-on-display-line-numbers-mode ()
> > > > +  "Turn on `display-line-numbers-mode'."
> > > > +  (unless (or (minibufferp)
> > > > +              ;; taken from linum.el
> > > > +              (and (daemonp) (null (frame-parameter nil 'client))))
> > > > +    (display-line-numbers-mode)))
> > >
> > > Could you make it use the "display-line-numbers-" prefix?
> > And then it doesn't need to be autoloaded.
>
> Done in 32daa3cb, thanks.  I know why I named it turn-on-foo, not sure
> why I autoloaded it.

Hmm, looking again--define-globalized-minor-mode mentions its TURN-ON
function.  Prefix-all-the-things aside, this looks weird to me for it to
be an internal function.