emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Why does make run git?


From: Tino Calancha
Subject: Re: Why does make run git?
Date: Tue, 1 Aug 2017 23:49:08 +0900 (JST)
User-agent: Alpine 2.20 (DEB 67 2015-01-07)



On Tue, 1 Aug 2017, Richard Stallman wrote:

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

 > > git config transfer.fsckObjects 'true'

 > This makes Git abort if it sees a bad object being pulled or pushed.

Isn't that a personal preference?  It seems wrong for Emacs to set it
arbitrarily.
It's recommended for security. It was discussed before being added:
https://lists.gnu.org/archive/html/emacs-devel/2016-01/msg01802.html

 > > git config diff.elisp.xfuncname 
'^\(def[^[:space:]]+[[:space:]]+([^()[:space:]]+)'
 > > git config diff.m4.xfuncname '^((m4_)?define|A._DEFUN(_ONCE)?)\([^),]*'
 > > git config diff.make.xfuncname 
'^([$.[:alnum:]_].*:|[[:alnum:]_]+[[:space:]]*([*:+]?[:?]?|!?)=|define .*)'
 > > git config diff.shell.xfuncname 
'^([[:space:]]*[[:alpha:]_][[:alnum:]_]*[[:space:]]*\(\)|[[:alpha:]_][[:alnum:]_]*=)'
 > > git config diff.texinfo.xfuncname 
'address@hidden:space:]]+([^,[:space:]][^,]+)'

 > These tailor the Git's notion of a "function" for the various
 > languages.  It's handy in several commands that need to know where a
 > function begins and ends.

Do you mean, several Git commands, or several Emacs commands?
I would guess it is the former.

Running make on the Emacs checkout seems like an inadequate place to
do this.  There is no assurance that you will run make in that
checkout before committing anything.

Perhaps there should be a function in Emacs that does this, and some
VC commands could call it.
I think is for convenience.  It is set there once and for all.  There
are plenty of Git interfaces for Emacs out of there: whatever an user
decide to use, s?he already has set up those hooks; then her/him potential contributions will be easier accepted.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]