Re: Emacs 26.1 release branch created

[Mark Oteiza]

On 22/09/17 at 08:11pm, Eli Zaretskii wrote:
> > Date: Fri, 22 Sep 2017 16:05:03 -0400
> > From: Mark Oteiza <address@hidden>
> > Cc: address@hidden
> > 
> > > Hmm... I'm probably missing something, because I don't understand the
> > > rationale and the intent of your changes.  You introduce a static
> > > function lcms2_available_p that is not used anywhere else in the file?
> > 
> > Oops, all the instances of replacing #ifdef'd code with
> > init_lcms_functions were meant to instead be calling lcms_available_p.
> > Hopefully that makes the intent clear.
> 
> Yes, clear.
> 
> > > And you removed lcms2-available-p without which Lisp code cannot know
> > > at run time whether lcms2 support is available or not?  Where does
> > > this lead?
> > 
> > I don't think having it in Lisp is necessary--isn't it essentially the
> > same as (featurep 'lcms2)?
> 
> No, not on MS-Windows.  An Emacs binary compiled with lcms2 support,
> then moved to a system where lcms2 libraries are not installed will
> return t from featurep, but the lcms2 functions will signal an error.

Ah, ok.  Thanks for the correction.