emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix for bug#29935 copyright-update inserts year at random places


From: Stefan Monnier
Subject: Re: fix for bug#29935 copyright-update inserts year at random places
Date: Mon, 08 Jan 2018 17:18:23 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

> `quit-restore-window' remembers what buffer the window it quits
> displayed before calling `with-temp-buffer-window' and also the
> respective `window-start' and `window-point' positions, sometimes also
> the window's size.

So it also remembers if the previous buffer was the same buffer?
Sounds like it would do the job, then.

Except that with-temp-buffer-window starts by erasing the buffer,
whereas here the buffer is already ready to be displayed (it's a file
buffer).

>>> So please tell what's missing in `with-temp-buffer-window'.
>> It forces scoping.
> Where and how?

I guess I was confused by the `with` in the name.

> IIUC your
>
>     (let ((x (temporary-display-buffer BUF)))
>
>     +
>
>     (temporary-undisplay-buffer x)
>
> would force scoping

No: the `x` could be stored anywhere you like.

> but `quit-restore-window' doesn't rely on any scoping.

Good.  So we just need to extract the "display-buffer" part of
with-temp-buffer-window?


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]