[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Preview: portable dumper
From: |
Eli Zaretskii |
Subject: |
Re: Preview: portable dumper |
Date: |
Fri, 16 Feb 2018 21:57:26 +0200 |
> From: Andy Moreton <address@hidden>
> Date: Fri, 16 Feb 2018 17:48:05 +0000
>
> On Fri 16 Feb 2018, Eli Zaretskii wrote:
> > When Angelo reported this, I said I didn't understand how a similar
> > code in sysdep.c:emacs_intr_read does compile without a problem,
> > although it seems to feed a ptrdiff_t value (which should be 64-bit
> > wide in the 64-bit Windows build, just like size_t, except for the
> > signedness), similarly to the above. Can you spot why that works?
>
> The difference is at the top of pdumper.c:
>
> #ifdef __GNUC__
> # pragma GCC diagnostic error "-Wconversion"
> # pragma GCC diagnostic error "-Wshadow"
>
> Everything else appears to be built without that warning as error. If I
> add similar pragmas to sysdep.c then it also emits a dozen or so
> conversion warnings as errors.
Ah, okay. So I guess we've just uncovered a subtle bug, which affects
emacs_intr_read as well, and perhaps other places. Thanks.
- Re: Preview: portable dumper, (continued)
- Re: Preview: portable dumper, Daniel Colascione, 2018/02/14
- Re: Preview: portable dumper, Daniel Colascione, 2018/02/14
- Re: Preview: portable dumper, Eli Zaretskii, 2018/02/14
- Re: Preview: portable dumper, Daniel Colascione, 2018/02/14
- Re: Preview: portable dumper, Eli Zaretskii, 2018/02/15
- Re: Preview: portable dumper, Andy Moreton, 2018/02/16
- Re: Preview: portable dumper, Eli Zaretskii, 2018/02/16
- Re: Preview: portable dumper, Andy Moreton, 2018/02/16
- Re: Preview: portable dumper, Eli Zaretskii, 2018/02/16
- Re: Preview: portable dumper, Andy Moreton, 2018/02/16
- Re: Preview: portable dumper,
Eli Zaretskii <=
- Re: Preview: portable dumper, Daniel Colascione, 2018/02/16
- Re: Preview: portable dumper, Paul Eggert, 2018/02/16
- Re: Preview: portable dumper, Daniel Colascione, 2018/02/16
- Re: Preview: portable dumper, Paul Eggert, 2018/02/16
- Re: Preview: portable dumper, Daniel Colascione, 2018/02/16
- Re: Preview: portable dumper, Paul Eggert, 2018/02/16
- Re: Preview: portable dumper, Robert Pluim, 2018/02/15
- Re: Preview: portable dumper, Robert Pluim, 2018/02/20
- Re: Preview: portable dumper, Daniel Colascione, 2018/02/20
- Re: Preview: portable dumper, Paul Eggert, 2018/02/20