Re: [Emacs-diffs] master 108ce84 2/2: xref--next-error-function: Move xref's window point

[Dmitry Gutov]

Eli, what would you say about backporting this to emacs-26?

This change is limited in scope, it fixes annoying "looping" behavior 
I've seen in some cases, and it adds window point movement you've asked 
for before in https://debbugs.gnu.org/cgi/bugreport.cgi?bug=20489#110

> branch: master
> commit 108ce84432d597f92637ea74bd0a094224d157de
> Author: Dmitry Gutov <address@hidden>
> Commit: Dmitry Gutov <address@hidden>
>
>      xref--next-error-function: Move xref's window point
>      
>      * lisp/progmodes/xref.el (xref--next-error-function): Move
>      xref's window point if it's visible.  When we don't do that,
>      navigation can start looping after a while.
> ---
>   lisp/progmodes/xref.el | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
> index 1c1fc59..5a9a7a9 100644
> --- a/lisp/progmodes/xref.el
> +++ b/lisp/progmodes/xref.el
> @@ -693,6 +693,10 @@ references displayed in the current *xref* buffer."
>       (dotimes (_ n)
>         (setq xref (xref--search-property 'xref-item backward)))
>       (cond (xref
> +           ;; Save the current position (when the buffer is visible,
> +           ;; it gets reset to that window's point from time to time).
> +           (let ((win (get-buffer-window (current-buffer))))
> +             (and win (set-window-point win (point))))
>              (xref--show-location (xref-item-location xref) t))
>             (t
>              (error "No %s xref" (if backward "previous" "next"))))))
>
> _______________________________________________
> Emacs-diffs mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/emacs-diffs