Re: suggestion for compile.el

[Dan Nicolaescu]

address@hidden (Daniel Pfeiffer) writes:

  > Dan Nicolaescu <address@hidden> skribis:
  > 
  > >  > I've only now had time to look at it, and I'm not happy with it.  It's 
a
  > >  > good
  > >   > idea to have different faces for a text console, which displays
  > >   > compilation nicely, and a terminal emulation under X, which currently
  > >   > does not.  But 16 seems to be the wrong min-colors, because at least 
my
  > >   > wterm doesn't notice. It would require this to be 15.
  > > 
  > > What would you want me to do? Should I prepare another patch, or are
  > > you going to take care of this? I am not sure I understand...
  > 
  > I don't really know.  It's good to improve things, but I have to understand
  > the issues, or at least see the result.

See my explanations below, please let me know if you need more
clarifications.

  > > How many colors does your wterm support ? (sorry I haven't heard of wterm
  > > until now).
  > 
  > I had tried your patch that way.  At 16 it didn't work, while at 15 it did. 
  > (I tried "yellow" for info, to be sure something changed).
  > 
  > > Can you do emacs -nw  then M-: (display-color-cells) RET  ? 
  > 
  > I had tried your patch that way.  This function in wterm, aterm or KDE's
  > konsole, always tells me 8.

Well, then the patch should not change anything for you. The
face colors for compile-* should be the same before and after the
patch. 

What the patch is trying to do is to make the terminals that support
at least 16 colors use the same colors as the X faces do. Anything
else should remain the same. All other cases are supposed to stay the
same. I was deliberately not trying to change any colors, just to
improve the support for terminals that support a high number of
colors.  
16 is chosen because dos/windows terminals support 16 colors. 

To see the effect of the patch it is best to use an xterm or rxvt
compiled with 256 (or 88) colors support. (I don't know if the
terminals that you use support a high number of colors). 


        --dan