emacs-pretest-bug
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: man command is broken


From: Nick Roberts
Subject: Re: man command is broken
Date: Thu, 17 Jun 2004 19:04:46 +0100

 > Can you figure out if the shell command that Emacs actually runs
 > is incorrect, and if so, how?

It fails because Man-build-man-command uses Bourne shell-type redirection (man
%s 2>/dev/null...). The original poster suggested the change concerned because
there is no program called sh on cygwin. I therefore suggest the change below
so that behaviour is only changed for cygwin. There may be other cases that
won't work but I think this conservative approach is more appropriate,
especially since we are meant to be approaching a release.

Nick



*** man.el      11 May 2004 18:53:22 +0100      1.134
--- man.el      17 Jun 2004 18:20:45 +0100      
***************
*** 733,739 ****
        (if (fboundp 'start-process)
            (set-process-sentinel
             (start-process manual-program buffer
!                           shell-file-name shell-command-switch
                            (format (Man-build-man-command) man-args))
             'Man-bgproc-sentinel)
          (let ((exit-status
--- 733,740 ----
        (if (fboundp 'start-process)
            (set-process-sentinel
             (start-process manual-program buffer
!                           (if (eq system-type 'cygwin) shell-file-name "sh")
!                           shell-command-switch
                            (format (Man-build-man-command) man-args))
             'Man-bgproc-sentinel)
          (let ((exit-status




reply via email to

[Prev in Thread] Current Thread [Next in Thread]