Re: describe-char

[Stefan Monnier]

>>> +   (setq help-xref-stack-item (list 'help-insert-string (buffer-string)))
>> 
>> This is wrong.  There are functions like help-setup-xref to do this job.

> The function help-setup-xref is already used in describe-char as

>     (help-setup-xref nil (interactive-p))

> It is called before the old contents of the help buffer is replaced with
> the output of `describe-char'.  This is necessary to record the previous
> position of point.  But since at this moment the help buffer doesn't contain
> the new output of `describe-char', we should use nil for the first
> argument `item' of the function `help-setup-xref' here, and should set
> `help-xref-stack-item' explicitly later when the help buffer is ready.

AFAICT it's the exact same situation as in all other cases, except that you
use (buffer-string).
Instead of using (help-insert-string (buffer-string)) I'd use
(describe-char pos buf), which admittedly forces you to add a `buf' optional
argument.

> Unless you propose a better solution, I will add a comment.

Thanks,


        Stefan