Compile-goto-error can signal wrong-type-argument

[Marshall, Simon]

This is a buggette in CVS head as of 2006-06-19.

src/emacs -Q
Start a compilation which is going to raise some errors.  Then mouse-1 on an
error to get the popup window "Find this error in (default ...)" for you to
navigate to the file.  (The error message doesn't contain enough info for
Emacs to be able to work it out itself.)  So far, so good.

In the popup, navigate to the wrong directory and click on OK without going
through the process of finding the file entry and selecting it first.  (You
can't - you're in the wrong directory!)

I get:

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  set-buffer(nil)
  (save-current-buffer (set-buffer (compilation-find-file marker ... ...))
(save-restriction (widen) (goto-char ...) (dolist ... ... ...)))
  (with-current-buffer (compilation-find-file marker (caar ...) (cadr ...))
(save-restriction (widen) (goto-char ...) (dolist ... ... ...)))
  (if (and (nth 3 loc) (marker-buffer ...)) nil (with-current-buffer
(compilation-find-file marker ... ...) (save-restriction ... ... ...)))
  (unless (and (nth 3 loc) (marker-buffer ...)) (with-current-buffer
(compilation-find-file marker ... ...) (save-restriction ... ... ...)))
  (let* ((columns compilation-error-screen-columns) (last 1) (loc ...)
(end-loc ...) (marker ...)) (setq compilation-current-error (point-marker)
overlay-arrow-position (if ... compilation-current-error ...) loc (car loc))
(unless (and ... ...) (with-current-buffer ... ...)) (compilation-goto-locus
marker (nth 3 loc) (nth 3 end-loc)) (setcdr (nthcdr 3 loc) t))
  compilation-next-error-function(0 nil)
  next-error-internal()
  compile-goto-error((mouse-2 (#<window 16 on *compilation*> 26077 (81 .
111) 85721490 nil 26077 (11 . 8) nil (4 . 7) (7 . 13))))
  call-interactively(compile-goto-error)

At the very least, Emacs should raise a more descriptive error.

Simon.

In GNU Emacs 22.0.50.1 (sparc-sun-solaris2.8, X toolkit)  of 2006-06-19 on
perth X server distributor `Hummingbird Ltd.', version 11.0.100015
configured using `configure '--with-x-toolkit=lucid' 'CFLAGS=-g''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: en_GB.ISO8859-1
  value of $LC_CTYPE: en_GB.ISO8859-1
  value of $LC_MESSAGES: C
  value of $LC_MONETARY: en_GB.ISO8859-1
  value of $LC_NUMERIC: en_GB.ISO8859-1
  value of $LC_TIME: en_GB.ISO8859-1
  value of $LANG: en_GB.ISO8859-1
  locale-coding-system: iso-8859-1
  default-enable-multibyte-characters: t

Major mode: C++/l

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  abbrev-mode: t