Re: switch-to-buffer incompatible behavior with Emacs 21

[Kim F. Storm]

Nick Roberts <address@hidden> writes:

> The comment suggests that this patch will create a problems.  Perhaps the
> patch below solves them.

I think the problem is just an oversight in the following change:

2003-07-15  Stefan Monnier  <address@hidden>

        * buffer.c
        (Fswitch_to_buffer): Don't signal an error when switching to the same
        buffer in a dedicated window.


Your patch looks good to me.


>
> -- 
> Nick                                           http://www.inet.net.nz/~nickrob
>
>
> *** buffer.c  23 Aug 2006 09:44:28 +1200      1.507
> --- buffer.c  24 Aug 2006 17:59:38 +1200      
> ***************
> *** 1684,1692 ****
>     char *err;
>   
>     if (EQ (buffer, Fwindow_buffer (selected_window)))
> !     /* Basically a NOP.  Avoid signalling an error if the selected window
> !        is dedicated, or a minibuffer, ...  */
> !     return Fset_buffer (buffer);
>   
>     err = no_switch_window (selected_window);
>     if (err) error (err);
> --- 1684,1696 ----
>     char *err;
>   
>     if (EQ (buffer, Fwindow_buffer (selected_window)))
> !     {
> !       if (NILP (norecord)  && !EQ (buffer, XCDR (XCAR (Vbuffer_alist))))
> !     record_buffer (buffer);
> !       /* Basically a NOP.  Avoid signalling an error if the selected window
> !      is dedicated, or a minibuffer, ...  */
> !       return Fset_buffer (buffer);
> !     }
>   
>     err = no_switch_window (selected_window);
>     if (err) error (err);

-- 
Kim F. Storm <address@hidden> http://www.cua.dk